You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging #469 (6fc64e7) into main (701478a) will decrease coverage by 1.79%.
Report is 1 commits behind head on main.
The diff coverage is 11.11%.
❗ Current head 6fc64e7 differs from pull request most recent head 24d9840. Consider uploading reports for the commit 24d9840 to get more accurate results
The reason will be displayed to describe this comment to others. Learn more.
are these changes to the written file definitely correct, bearing in mind the user might not use capacitor? And I'm not sure vue-vite is right:
To support this, we’ve introduced a new project type in the ionic.config.json, vue-vite and react-vite. These new project types will tell the CLI that it should call Vite when you run ionic serve or ionic build. https://ionic.io/blog/ionic-cli-v7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of right now, the app name for the to-be-generated
ionic.config.jsonis derived from the localpackage.json. This results in the followingappName:But the official Ionic configuration recommends:
I believe a better approach is to use any of the existing Capacitor configs, as it includes the to be published app name:
capacitor.config.jsoncapacitor.config.tsSince a valid
namefor apackage.jsonisn't allowed to include uppercase letters, the Capacitor config holds the more appropriate app name.